Styling: Add .destructive class for button.text-button#870
Merged
danirabbit merged 9 commits intomainfrom Apr 2, 2026
Merged
Conversation
danirabbit
reviewed
May 27, 2025
wpkelso
force-pushed
the
wpkelso/styles/button-destructive
branch
from
acfeea0 to
f6bb826
Compare
Member
|
I don't think this works in the dark style:
Compared to the old stylesheet:
|
Member
Author
|
@danirabbit Ah, you're right, I totally didn't check that. Should probably just use SILVER_100 foreground for both cases? I'm afk right now so I can't verify that provides sufficient contrast for dark mode as well, but if it doesn't then we might need to modify the dark mode error color |
Member
|
@wpkelso in the old stylesheet we just use |
danirabbit
requested changes
Mar 23, 2026
| text-shadow: none; | ||
|
|
||
| &:active { | ||
| background-color: mix($error_color, $BLACK_900, 90%); |
Member
There was a problem hiding this comment.
We never want to mix with black because it makes colors muddy and reduces saturation. When colors get darker they should get more saturated. So it would be better to mix with Strawberry 700 or 900
danirabbit
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image excluded for now because I don't believe there is a precedent style.