Skip to content

Rewrite display widget #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danirabbit wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Rewrite display widget #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
91d8a93
Rewrite display widget
danirabbit Feb 15, 2023
39090cf
Update main.yml
danirabbit Feb 15, 2023
511ab51
Create different item types for different devices
danirabbit Feb 15, 2023
d2ace86
Add back wifi animation
danirabbit Feb 15, 2023
130bde5
Update license header
danirabbit Feb 15, 2023
8fe5367
Add transition type
danirabbit Feb 15, 2023
1c4d800
Fix preserving extra space
danirabbit Feb 16, 2023
1aa7d5f
Remove some unused stuff
danirabbit Feb 16, 2023
5045d92
Merge master
danirabbit Feb 16, 2023
c04114f
Uncomment hotspot item
danirabbit Feb 16, 2023
c4053ca
Missed a comment
danirabbit Feb 16, 2023
e77b1c5
Don't support HotSpot for now
danirabbit Feb 16, 2023
e80b935
Handle modem theoretically
danirabbit Feb 16, 2023
abdb113
Remove some unused
danirabbit Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest

container:
image: elementary/docker:unstable
image: elementary/docker:next-unstable

steps:
- uses: actions/checkout@v3
Expand Down
14 changes: 1 addition & 13 deletions src/Indicator.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ public class Network.Indicator : Wingpanel.Indicator {
display_widget = new Widgets.DisplayWidget ();

popover_widget = new Widgets.PopoverWidget (is_in_session);
popover_widget.notify["state"].connect (on_state_changed);
popover_widget.notify["secure"].connect (on_state_changed);
popover_widget.notify["extra-info"].connect (on_state_changed);
popover_widget.notify["state"].connect (update_tooltip);
popover_widget.settings_shown.connect (() => { close (); });

if (is_in_session) {
Expand All @@ -56,7 +54,6 @@ public class Network.Indicator : Wingpanel.Indicator {
}

update_tooltip ();
on_state_changed ();
start_monitor ();
}

Expand All @@ -68,15 +65,6 @@ public class Network.Indicator : Wingpanel.Indicator {
return popover_widget;
}

void on_state_changed () {
assert (popover_widget != null);
assert (display_widget != null);

display_widget.update_state (popover_widget.state, popover_widget.secure, popover_widget.extra_info);

update_tooltip ();
}

private void start_monitor () {
network_monitor = NetworkMonitor.get_default ();

Expand Down
Loading