Merged
Conversation
Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
Marukesu
force-pushed
the
maru/notifications-monitor
branch
from
c66eb0f to
8db3af7
Compare
Marukesu
force-pushed
the
maru/notifications-monitor
branch
from
8db3af7 to
c79006e
Compare
GLib.DBusProxy cannot be used to emit signals in the bus. Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
the [SingleInstance] attribute deal with making the class a singleton and forcing a unique instance is created and referenced everytime the constructor method is called, sealed mark the class as non-derivable. while here fix the class name to match the file name. Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
rather than calling initialize() in the construct block make it public and let the Indicator decides when to initalize the monitor. Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
use a generic match for method calls and signal emissions for the org.freedesktop.Notifications interface, restrict the method_return and error ones to the org.freedesktop.Notifications name. Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
rewrite the switch statement to check member_name instead of message_type, this allow to mege the CloseNotification and NotificationClosed cases. the case of the notify call beeing successfull or not is also merged. the monitor signals are now emitted before the next Gtk redraw cycle, making sure that the tray got updated in the current cycle. Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
Marukesu
force-pushed
the
maru/notifications-monitor
branch
from
c79006e to
76943d1
Compare
zeebok
approved these changes
Aug 24, 2023
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
I think this looks good from what I understand of how this works. I am not totally sure how to best test this. if you want me to let me know but I trust you enough with this that I am fine with you merging.
Member
|
This is also working for me and I can confirm replaces are working. Nice work! Way to save 100 lines as well, very cool diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup the class and make the filter simple.
Depends on elementary/notifications#211.
Closes #9.