Internal: Update Elementor install in daily test matrix [TMZ-1028]#628
Open
Internal: Update Elementor install in daily test matrix [TMZ-1028]#628
Conversation
There was a problem hiding this comment.
Pull request overview
Updates CI wp-env generation to reduce Elementor version drift between build and test jobs by preferring a locally downloaded Elementor artifact (when present/valid), with simpler fallback behavior and less noisy logging.
Changes:
- Prefer
./tmp/elementoras the Elementor plugin source when it looks like a valid artifact. - Fall back to WordPress.org downloads for semantic versions, otherwise default to
latest-stable. - Remove extensive Elementor artifact debug logging from the script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Removed excessive debug logging from Elementor installation logic in CI test matrix (TMZ-1028). The previous implementation had verbose emoji-laden debug output and complex branching that made logs noisy. Simplified to a cleaner validation check with fallback to WordPress.org versions when local artifacts aren't available.
2. What Changed (Where)
.github/scripts/build-wp-env.js: Refactored Elementor plugin installation logic, removed ~100 lines of debug logging, simplified version resolution3. How It Works
Validates local Elementor build by checking for three essential files (
elementor.php,includes/,assets/). If valid, uses./tmp/elementor; otherwise extracts semantic version fromELEMENTOR_VERSIONenv var and downloads from WordPress.org. Removed the previous fallback-on-error logic that masked build failures. Logs now show actual source used (elementorSource) instead of requested version.4. Risks
None. This is cleanup of debug code. The core logic (local build validation → WordPress.org fallback) remains functionally equivalent, just cleaner. The removal of the error-masking fallback actually improves CI signal by failing fast on invalid builds rather than silently falling back to latest-stable.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how