commiting notebook for modelling of count data using ELFI#10
Open
adhaka wants to merge 1 commit intoelfi-dev:masterfrom
Open
commiting notebook for modelling of count data using ELFI#10adhaka wants to merge 1 commit intoelfi-dev:masterfrom
adhaka wants to merge 1 commit intoelfi-dev:masterfrom
Conversation
|
Very nice notebook, I like it a lot. Some things:
Otherwise, it's an excellent notebook. |
|
I found the notebook to be quite interesting and it demonstrated some nice concepts. To add to the above comments:
Overall, good effort! 👍 |
vuolleko
requested changes
May 16, 2018
Member
There was a problem hiding this comment.
Very good notebook. Some requests:
- more explanations (even brief ones)
- there's a remaining TODO. Either do it or remove it. :)
- there are titles "Ricker's Model" and "Specify the model(Simulator) for generating synthetic obervations" with no content?
DistanceMeasures.DTWseems to recurse?- the Ricker model is provided under elfi.examples; the code seems mostly identical. Coincidence? Source for copied code MUST be identified (after verifying its licence allows usage under BSD3!)
- what's
model_trial2? - no need for an "identity" summary node, just make the simulator a parent for distance directly
- please discuss results
- in Out [60] (plot_marginals), something is clearly wrong with
t1 - the pools are unused
- what's with the commented-out lines?
- overall cleaning
- move the notebook to zoo/notebooks/elfi-Poisson-Milestone2.ipynb (what's the milestone?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a notebook where I try out a few different things. To summarise I have tried to:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Akash Kumar Dhaka
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: