Conversation
eliel9012
commented
May 24, 2026
Owner
Author
eliel9012
left a comment
There was a problem hiding this comment.
Font review:
- Good direction: the fix addresses the actual root cause. SwiftUI root
.font(...)does not override explicit child calls like.font(.system(...)),.font(.headline),.font(.title3), etc. Replacing those in the visible screens is necessary. - The Mac OS 9 default UI font should be
Charcoalfor the app chrome and controls. Apple Garamond should stay limited to editorial/display moments, not global UI titles. This PR now follows that. - UIKit appearance is now applied in
MeuLabApp.init(), which is important for navigation/tab bars because appearance proxies need to be configured before the relevant UIKit views are created. - Font registration looks correct:
UIAppFontsincludes Charcoal/Geneva/Apple Garamond and the PostScript names used byMacOS9Typographymatch the bundled files. - Residual risk: SF Symbols still render with Apple system glyphs. That is expected unless custom bitmap/classic icons are introduced later. Text around those icons now uses the Mac OS 9 typography tokens.
Build verified with generic iOS destination.
Owner
Author
|
Update after layout review:
Verification: |
Owner
Author
|
Atualizei este PR com foco no problema de abertura lenta e fonte da Rádio/SDR.
Validação: xcodebuild -project MeuLabApp.xcodeproj -scheme MeuLabApp -destination 'generic/platform=iOS' build passou. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font review
This PR fixes the Mac OS 9 typography pass. The previous global
.mac9Theme()font was not enough because many SwiftUI views explicitly set.system,.headline,.title,.caption, rounded, or monospaced fonts. Those explicit calls override the root environment font.What changed
MeuLabApp.init()so navigation/tab bars pick up the theme before rendering.Charcoalas the standard Mac OS 9 UI font for navigation bars, tab bar labels, app text, chips, cards, and main screen labels.Mais,Bíblia,Clima, andADS-B.Review notes
UIAppFontsand included in the Xcode resources.Charcoal.ttfresolves to PostScript nameCharcoal;Geneva.ttfresolves toGenevaPlain; Apple Garamond names also resolve correctly.Verification
xcodebuild -project MeuLabApp.xcodeproj -scheme MeuLabApp -destination 'generic/platform=iOS' build\n- Build succeeded.\n\n### Secret safety\n- No.env, tokens,Secrets.plist,Secrets.xcconfig, or Swift secrets were staged.