Skip to content

Add {:unsafe_fragment, ...} support to RETURNING clause #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryzhan013 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

Add {:unsafe_fragment, ...} support to RETURNING clause #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/ecto/adapters/postgres/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,6 +1204,9 @@ if Code.ensure_loaded?(Postgrex) do
defp returning([]),
do: []

defp returning({:unsafe_fragment, fragment}),
do: [" RETURNING ", fragment]

defp returning(returning),
do: [" RETURNING " | quote_names(returning)]

Expand Down
4 changes: 4 additions & 0 deletions test/ecto/adapters/postgres_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,6 +1877,10 @@ defmodule Ecto.Adapters.PostgresTest do

query = insert("prefix", "schema", [], [[]], {:raise, [], []}, [])
assert query == ~s{INSERT INTO "prefix"."schema" VALUES (DEFAULT)}

# With unsafe_fragment in returning
query = insert(nil, "schema", [:x, :y], [[:x, :y]], {:raise, [], []}, {:unsafe_fragment, ~s{"id", ("x" = "y") AS "was_equal"}})
assert query == ~s{INSERT INTO "schema" ("x","y") VALUES ($1,$2) RETURNING "id", ("x" = "y") AS "was_equal"}
end

test "insert with on conflict" do
Expand Down