properly handle decimal exponents #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkuku
force-pushed
the
decimal_exponent_handling
branch
from
3d99032 to
082effa
Compare
Member
billylanchantin
left a comment
billylanchantin
left a comment
There was a problem hiding this comment.
I implemented it with claude code.
Thanks for the clarity! We definitely want developers to let us know when they do this. We should probably write up a policy...
dkuku
force-pushed
the
decimal_exponent_handling
branch
from
ead3a33 to
29ef928
Compare
dkuku
force-pushed
the
decimal_exponent_handling
branch
from
c4080f5 to
a53c8b2
Compare
dkuku
force-pushed
the
decimal_exponent_handling
branch
from
a53c8b2 to
67efdae
Compare
billylanchantin
approved these changes
Oct 13, 2025
Member
billylanchantin
left a comment
billylanchantin
left a comment
There was a problem hiding this comment.
Thank you, @dkuku! Great work!
I appreciate you tackling that issue :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a try on the decimal exponent handling. This is the result:
1.5e10) by multiplying the coefficient during conversionchecked_multo reject values that don't fit in i128Tests cover mixed exponent arithmetic and overflow cases.
closes #1123
I implemented it with claude code. The max precision for decimal is 38 according to the docs because internally it is backed by i128.