Create Protobuf.Presence module#403
Merged
v0idpwn merged 3 commits intofeat/text-encodingfrom Apr 15, 2025
Merged
Conversation
0e75db0 to
e0f7de6
Compare
Unifies presence tracking between encoders. Provides a public API for checking field presence
6314c1b to
79745cc
Compare
Collaborator
Author
|
I will merge this to #398, and continue working from there. If you have any feedback, you can give it either here or there :) |
Collaborator
|
I love this but I would expose the function on the |
Collaborator
Author
|
Great idea, will do! |
v0idpwn
added a commit
that referenced
this pull request
Apr 30, 2025
* Create Protobuf.Presence module Unifies presence tracking between encoders. Provides a public API for checking field presence * Add test for messages, fix proto3 * Improve docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is on-top of #398.
Adds a unified presence tracking module. Makes the different encoders use it when deciding whether to skip a field or not.
Adds a public API for checking field presence on
Protobuf.Presence.field_presence/2. This is similar to the feature present on the official protobuf libraries, but with a different API.In Ruby, for example, fields that have explicit presence tracking generate a
has_{field_name}?method:If another field, say
bar, doesn't have explicit presence tracking (e.g.: it is a non-optional, non-one_of proto3), it simply doesn't generate thehas_bar?method, so you can't "presence-check" these fields.My proposed API is a bit different, and allows presence-checking
:bar, but sometimes givinga
:maybeas a response:Motivation
I think it makes sense to centralize presence checking for a few reasons:
Protobuf.Text.