Conversation
|
@nyo16 this breaks compatibility with older versions. We can bump version req to 1.15 but we'll need to address those if they are problematic there as well. Could you take a look? |
The ^ pin operator in binary size specifiers (e.g. bytes-size(^value)) was introduced in Elixir 1.16.0. Update the minimum version requirement and CI matrix accordingly.
|
Thanks for the review! I dug into this — the ^ pin operator in binary size specifiers was introduced in Elixir 1.16.0 (verified against the compiler source), so bumping to 1.15 alone That said, these are just warnings on Elixir 1.20, not errors — the code without ^ still compiles and works fine. So if maintaining broader compatibility is more important, it's totally If you do want to address them, I've updated the PR to:
Happy to go either way — let me know what you prefer. |
^) to variables used insidesize(...)in bitstring patterns, as required by Elixir 1.20size(...)Protobuf.Decoder(3 locations) andProtobuf.JSON.RFC3339(2 locations)Test plan
mix compile --force --all-warningsproduces 0 warningsmix test— all 483 tests pass with no failures"2>&1