Merged
Conversation
locks
force-pushed
the
ember-3-25
branch
2 times, most recently
from
1206f7d to
040ce2e
Compare
jenweber
reviewed
Feb 25, 2021
jenweber
approved these changes
Feb 25, 2021
Contributor
jenweber
left a comment
jenweber
left a comment
There was a problem hiding this comment.
Looks good, minus the typo mentioned above. Thank you!
Co-authored-by: Jen Weber <j@jenweber.me>
jaredgalanis
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Changelogs
ember-source
<LinkTo />prior to routing (e.g. component rendering tests)@glimmer/*0.74.2 for various features and bugfixes including ensuring{{component.name}}works with implicit this fallbackhtmlSafestring to be treated as falsydeprecateoptions (for+since)ember-data
ember-cli