Fixed solar battery calculation logic, breaking change! now supports battery export to grid#215
Open
TrystanLea wants to merge 165 commits into
Open
Fixed solar battery calculation logic, breaking change! now supports battery export to grid#215TrystanLea wants to merge 165 commits into
TrystanLea wants to merge 165 commits into
Conversation
…battery export to grid
…culations, could be useful in future
MrTimbones
reviewed
May 16, 2026
Comment on lines
+276
to
+280
| // If the feed is more than 1 hour behind then start the view at the end of the feed | ||
| if ((view.end*0.001-power_graph_end_time)>3600) { | ||
| view.end = power_graph_end_time*1000; | ||
| autoupdate = false; | ||
| } |
Contributor
There was a problem hiding this comment.
I keep this app open in a tab on my phone, and check on it periodically throughout the day. Trouble is, whenever the web browser is suspended and later resumed, the app will jump to an old time period.
I find it works better without this block so that autoupdate stays on and refreshes to the current time.
Suggested change
| // If the feed is more than 1 hour behind then start the view at the end of the feed | |
| if ((view.end*0.001-power_graph_end_time)>3600) { | |
| view.end = power_graph_end_time*1000; | |
| autoupdate = false; | |
| } |
Member
Author
There was a problem hiding this comment.
Thanks @MrTimbones ! I will get back to you properly on the forum thread as well soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculations are fixed in the detailed power view so far, still need to fix the historic daily kWh data view.
See also: https://community.openenergymonitor.org/t/my-solar-pv-battery-app/14113/152