Use css injector - The current state of CSS handling + Solutions#2017
Draft
davidglezz wants to merge 9 commits intomainfrom
Draft
Use css injector - The current state of CSS handling + Solutions#2017davidglezz wants to merge 9 commits intomainfrom
davidglezz wants to merge 9 commits intomainfrom
Conversation
Signed-off-by: davidglezz <davidg@empathy.co>
Signed-off-by: davidglezz <davidg@empathy.co>
Signed-off-by: davidglezz <davidg@empathy.co>
Signed-off-by: davidglezz <davidg@empathy.co> feat(home): update BaseTeleport demo Signed-off-by: davidglezz <davidg@empathy.co>
Signed-off-by: davidglezz <davidg@empathy.co>
9de16c8 to
565b974
Compare
Signed-off-by: davidglezz <davidg@empathy.co>
0a1a4a5 to
3692fa8
Compare
Draft
Signed-off-by: davidglezz <davidg@empathy.co>
Signed-off-by: davidglezz <davidg@empathy.co>
3692fa8 to
84ea2bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request template
We have special needs... tenemos necesidades especiales con respecto al manejo de css,
necesitamos tener el control de donde y cuando se inyecta el css, lo mas basico es:
Actualmente se hace con el plugin de rollup styles, que permite inyectar el css en una variable y añadir código js para decidir que hacer con ello. Esto, ademas, lo hace por cada "import" es decir, el css de cada componente se encuentra en una variable en el js de su componente. Permitiendo que si solo se usan 3 componentes, el bundle solo incluye esos 3 componentes con su css, nada mas.
Se quiere dejar de usar rollup por:
Pero:
Esta PR:
customElementa true, esto no significa que convierta los componentes a custom element, solo mete el css como parte del componente para que funcione con el uso de defineCustomElement que no usaremos.