Skip to content

fix(history-queries): use uiLang for dates and capitalize first letter #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

fix(history-queries): use uiLang for dates and capitalize first letter #2018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/x-components/src/x-modules/history-queries/components/my-history.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,11 @@ export default defineComponent({
*/
const usedLocale = computed(() => snippetConfig?.lang ?? props.locale)

const uiLocale = computed(() => snippetConfig?.uiLang ?? props.locale)

/**
* Returns a record of history queries grouped by date.
* Returns a record of history queries grouped by date, using the UI language (`uiLang`) for locale.
* The first character of the date is capitalized to ensure proper display in languages like Spanish.
*
* @example
* ```typescript
Expand All @@ -155,12 +158,13 @@ export default defineComponent({
*/
const groupByDate = computed((): Dictionary<HistoryQueryType[]> => {
return groupItemsBy(historyQueries.value as HistoryQueryType[], current => {
return new Date(current.timestamp).toLocaleDateString(usedLocale.value, {
const dateStr = new Date(current.timestamp).toLocaleDateString(uiLocale.value, {
day: 'numeric',
weekday: 'long',
month: 'long',
year: 'numeric',
})
return dateStr.charAt(0).toUpperCase() + dateStr.slice(1)
})
})

Expand Down
Loading