[embind] Add iterable protocol support for bound classes #25993
+235
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Dec 22, 2025
| const makeIterator = (size, getValue) => { | ||
| const useBigInt = typeof size === 'bigint'; | ||
| const one = useBigInt ? 1n : 1; | ||
| let index = useBigInt ? 0n : 0; |
Collaborator
There was a problem hiding this comment.
Could we simply dictate that interables using size_t i.e. bigint on wasm64 and number on wasm32?
I don't image we will ever see 64-bit iterators on wasm32, right?
Contributor
Author
There was a problem hiding this comment.
I tried doing this, but register_vector seems to use unsigned int on purpose, so I presume forcing Bigint on wasm64 is undesirable?
Add `class_<T>::iterable()` to implement `Symbol.iterator`. Use this in `register_vector` so bound vectors have better ergonomics, such as working with `for...of` and `Array.from()`. This is tangentially related to emscripten-core#11070.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
class_<T>::iterable()to implementSymbol.iterator. Use this inregister_vectorso bound vectors have better ergonomics, such as working withfor...ofandArray.from().This is tangentially related to #11070 in that it's intended to make vector bindings nicer to use, but unlike what is suggested there it doesn't copy the vector to JS memory.