Skip to content

Use addToLibrary rather than mergeInto in test code. NFC #26002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Dec 23, 2025
Merged

Use addToLibrary rather than mergeInto in test code. NFC #26002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/test_jslib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def test_jslib_invalid_decorator(self):
@also_without_bigint
def test_jslib_i53abi(self):
create_file('lib.js', r'''
mergeInto(LibraryManager.library, {
addToLibrary({
jslibfunc__i53abi: true,
jslibfunc__sig: 'j',
jslibfunc: (x) => { return 42 },
Expand All @@ -307,7 +307,7 @@ def test_jslib_i53abi(self):

def test_jslib_i53abi_errors(self):
create_file('lib.js', r'''
mergeInto(LibraryManager.library, {
addToLibrary({
jslibfunc__i53abi: true,
jslibfunc: (x) => { return 42 },
});
Expand All @@ -316,7 +316,7 @@ def test_jslib_i53abi_errors(self):
self.assertContained("error: JS library error: '__i53abi' decorator requires '__sig' decorator: 'jslibfunc'", err)

create_file('lib.js', r'''
mergeInto(LibraryManager.library, {
addToLibrary({
jslibfunc__i53abi: true,
jslibfunc__sig: 'ii',
jslibfunc: (x) => { return 42 },
Expand All @@ -336,6 +336,7 @@ def test_jslib_invalid_proxy_mode(self):
self.assertContained("error: JS library error: invalid proxying mode 'jslibfunc__proxy: foo' specified", err)

def test_jslib_legacy(self):
# Test that the legacy `mergeInfo` function work instead of `addToLibrary`
create_file('lib.js', r'''
mergeInto(LibraryManager.library, {
jslibfunc: (x) => { return 42 },
Expand Down