Skip to content

[test] Remove --experimental-wasm-type-reflection from v8 flags. NFC #26005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Dec 23, 2025
+1 −3
Merged

[test] Remove --experimental-wasm-type-reflection from v8 flags. NFC #26005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,17 +521,15 @@ def require_jspi(self):
if self.is_browser_test():
return

exp_args = ['--experimental-wasm-stack-switching', '--experimental-wasm-type-reflection']
# Support for JSPI came earlier than 22, but the new API changes require v24
if self.try_require_node_version(24):
self.node_args += exp_args
self.node_args += ['--experimental-wasm-stack-switching']
return

v8 = self.get_v8()
if v8:
self.cflags.append('-sENVIRONMENT=shell')
self.js_engines = [v8]
self.v8_args += exp_args
return

self.fail('either d8 or node v24 required to run JSPI tests. Use EMTEST_SKIP_JSPI to skip')
Expand Down