Skip to content

Error if __async decorator applied to JS-only symbol #26006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

Error if __async decorator applied to JS-only symbol #26006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/lib/libpthread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,9 +1077,6 @@ var LibraryPThread = {
'$runtimeKeepaliveCounter',
#endif
],
#if ASYNCIFY
$invokeEntryPoint__async: true,
#endif
$invokeEntryPoint: {{{ asyncIf(ASYNCIFY == 2) }}}(ptr, arg) => {
#if PTHREADS_DEBUG
dbg(`invokeEntryPoint: ${ptrToString(ptr)}`);
Expand Down
7 changes: 7 additions & 0 deletions src/utility.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,13 @@ export function mergeInto(obj, other, options = null) {
const decoratorName = key.slice(index);
const type = typeof other[key];

if (decoratorName == '__async') {
const decorated = key.slice(0, index);
if (isJsOnlySymbol(decorated)) {
error(`__async decorator applied to JS symbol: ${decorated}`);
}
}

// Specific type checking for `__deps` which is expected to be an array
// (not just any old `object`)
if (decoratorName === '__deps') {
Expand Down
Loading