Skip to content

Conversation

@emircanerkul
Copy link

Renaming

Additional Note:

When doing your local test you can switch your repo with this patch.

diff --git a/src/util/getAvailableStarters.ts b/src/util/getAvailableStarters.ts
index b0bd207..a752384 100644
--- a/src/util/getAvailableStarters.ts
+++ b/src/util/getAvailableStarters.ts
@@ -10,7 +10,8 @@ export default function getAvailableStarters(): EmulsifyStarter[] {
     {
       platform: 'drupal',
       platformMajorVersion: 9,
-      repository: 'https://github.com/emulsify-ds/emulsify-drupal.git',
+      repository:
+        'https://github.com/emircanerkul/emulsify-ds-emulsify-drupal.git',
       checkout: 'master',
     

@callinmullaney
Copy link
Contributor

@mikeethedude Can you take a look at this one? The renaming of the style.css to global.css is cool with me. There is another line in that file that points to someones specific home folder cornflakes that I think needs to be cleaned up somehow.

@callinmullaney callinmullaney added the 👍 Ready for Review Work is ready for review. label Mar 23, 2023
@mikeethedude
Copy link
Contributor

mikeethedude commented Mar 23, 2023

Cornflake is okay because that's what the test is expecting so I'm not worried about that. This seems like it is just updating the test? We don't do much else with that so I think it is correct to only need to update the test.

@amazingrando
Copy link
Contributor

@callinmullaney @mikeethedude I've created a PR for changing the test string at #252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👍 Ready for Review Work is ready for review.

Projects

No open projects
Status: Review/QA

Development

Successfully merging this pull request may close these issues.

5 participants