NXT-9751: Add ui tests from enact/i18n to agate#856
Open
alexandrumorariu wants to merge 2 commits intodevelopfrom
Open
NXT-9751: Add ui tests from enact/i18n to agate#856alexandrumorariu wants to merge 2 commits intodevelopfrom
alexandrumorariu wants to merge 2 commits intodevelopfrom
Conversation
…jenkins jobs. Changed travis file to reflect the change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #856 +/- ##
========================================
Coverage 85.08% 85.08%
========================================
Files 118 118
Lines 4491 4491
Branches 1226 1226
========================================
Hits 3821 3821
Misses 517 517
Partials 153 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - npm link | ||
| - popd | ||
| - git clone --branch=develop --depth 1 https://github.com/enactjs/enact ../enact | ||
| - git clone --branch=feature/NXT-9751 --depth 1 https://github.com/enactjs/enact ../enact |
Contributor
There was a problem hiding this comment.
to revert before merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Added ui-tests for enact/i18n in agate library so we can run them injenkins jobs. Changed travis file to reflect the change.
Resolution
Additional Considerations
Before merge please change the target enact branch back to develop in the travis file.
Links
NXT-9751
Comments