WRQ-27312: Add root node_modules directory in ILIB_BASE_PATH#350
Open
WRQ-27312: Add root node_modules directory in ILIB_BASE_PATH#350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
In WRQ-26798, work to remove lerna from enact is in progress.
When testing WRQ-26798,
npm run testfails in enact/i18n as Jest cannot find ilib that resides not under i18n/node_modules anymore but under the root node_modules.So, maybe 'jest.config.js' of CLI needs to be updated.
Resolution
Add root node_modules directory in
ILIB_BASE_PATHAdditional Considerations
Links
WRQ-27312
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)