Open
Conversation
Member
|
It will be important to verify that this change works well on pages with varying lengths of content; (some that have a scroller, some that don't). There was extensive testing done on screen sizes and page layout for all types and amounts of content, sidebar content amount, and all scenarios like those. |
Member
Author
|
Yep, the proposed change makes
What would make it better is if the |
Contributor
|
Let's discuss when @Djspaceg returns. It's definitely an improvement, but I think we might can do it even better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
sidebarto have dynamic height andoverscrollso that scrolling the sidebar won't affect the scrolling of the main content.Also resized the
sidebar's width to make room for the scrollbar.**maybe have
sidebarposition fixed, so that its height is the height of the window?The only thing I haven't figured out is how to shrink the
sidebarheight to make way for the footer when scrolling the main content to the bottom.Enact-DCO-1.0-Signed-off-by: Teck Liew teck.liew@lge.com