Skip to content

NXT-8190: Fixed VirtualList to be responsive while resizing window#3382

Merged
ion-andrusciac-lgp merged 8 commits intodevelopfrom
feature/NXT-8190
Feb 5, 2026
Merged

NXT-8190: Fixed VirtualList to be responsive while resizing window#3382
ion-andrusciac-lgp merged 8 commits intodevelopfrom
feature/NXT-8190

Conversation

@vJIYEv
Copy link
Copy Markdown
Contributor

@vJIYEv vJIYEv commented Jan 27, 2026

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

VirtualList items are not resized properly before reloading the app.

Resolution

  1. This issue is similar to NXT-577: Fixed VirtualGridList to be responsive while resizing window #3374
    but different because itemSize is Number type, immutable.
    I want to change itemSize value in useScroll like mutable value, so applied useState to itemSize.
  2. If VirtualList items have different sizes, I should change each child of itemSizes.
    So I scaled each child of itemSizes but this doesn't require useState because itemSizes is Object type, mutable.
  3. If "item size" is changed from VirtualList sample, "itemSize" should be changed too.
    So I made "originalItemSize" state and if originalItemSize is different with new item size, change the itemSize state.

Additional Considerations

https://github.com/enactjs/limestone/pull/297 resolves the issue on the (sample) app side.

Links

NXT-8190

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.38%. Comparing base (2011a8d) to head (dc7714b).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3382      +/-   ##
===========================================
+ Coverage    83.24%   83.38%   +0.14%     
===========================================
  Files          154      154              
  Lines         7258     7320      +62     
  Branches      1919     1945      +26     
===========================================
+ Hits          6042     6104      +62     
  Misses         956      956              
  Partials       260      260              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vJIYEv and others added 5 commits January 27, 2026 17:34
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Copy link
Copy Markdown
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ion-andrusciac-lgp ion-andrusciac-lgp merged commit 1d7f33d into develop Feb 5, 2026
8 checks passed
@ion-andrusciac-lgp ion-andrusciac-lgp deleted the feature/NXT-8190 branch February 5, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants