Skip to content

Implement CodeQL Security Scan in workflow #9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miguelgual2003 wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −0
Open

Implement CodeQL Security Scan in workflow #9871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,27 @@ jobs:
run: pylinkvalidate.py -P http://localhost:8000/

- run: echo "Done"

codeql:
name: CodeQL Security Scan
runs-on: ubuntu-latest

permissions:
security-events: write
contents: read

Comment on lines +83 to +86
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job requests security-events: write, which GitHub does not grant to workflows triggered from forked PRs. Since the workflow runs on pull_request, this job is likely to fail for external contributors. Consider guarding the job/steps to skip on forks, or run CodeQL only on push/schedule (or use pull_request_target with appropriate hardening).

Copilot uses AI. Check for mistakes.
steps:
- name: Checkout code
uses: actions/checkout@v4
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout version is inconsistent with the rest of the repo workflows (this file and others use actions/checkout@v6). Aligning the version here avoids unexpected behavior/security patch differences across jobs.

Suggested change
uses: actions/checkout@v4
uses: actions/checkout@v6

Copilot uses AI. Check for mistakes.

- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: python
queries: security-and-quality

# Para Python NO hace falta build ni dependencias
# CodeQL analiza el código fuente directamente
Comment on lines +97 to +98
Copy link
Member

@browniebroke browniebroke Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these comments or write them in English... From my basic Spanish they don't seem to add a lot of value, so I would lean towards removing

Comment on lines +97 to +98
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added inline comments are in Spanish, while the rest of the workflows in this repo are written in English. Please translate these to English to keep CI configuration maintainable for the broader contributor base.

Suggested change
# Para Python NO hace falta build ni dependencias
# CodeQL analiza el código fuente directamente
# For Python, no build or dependencies are required
# CodeQL analyzes the source code directly

Copilot uses AI. Check for mistakes.

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
Loading