Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rest_framework/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -1754,7 +1754,10 @@ def get_value(self, dictionary):
# We override the default field access in order to support
# dictionaries in HTML forms.
if html.is_html_input(dictionary):
return html.parse_html_dict(dictionary, prefix=self.field_name)
value = html.parse_html_dict(dictionary, prefix=self.field_name)
if not value and getattr(self.root, 'partial', False):
return empty
return value
return dictionary.get(self.field_name, empty)

def to_internal_value(self, data):
Expand Down
8 changes: 8 additions & 0 deletions tests/test_fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -2522,6 +2522,14 @@ def test_allow_empty_disallowed(self):

assert exc_info.value.detail == ['This dictionary may not be empty.']

def test_partial_update_does_not_include_missing_html_dict_field(self):
class TestSerializer(serializers.Serializer):
field_name = serializers.DictField(required=False)

serializer = TestSerializer(data=QueryDict(''), partial=True)
assert serializer.is_valid()
assert 'field_name' not in serializer.validated_data


class TestNestedDictField(FieldValues):
"""
Expand Down