Add context menu with duplicate#341
Conversation
Adds a context menu with duplicate, summary, pin, and delete functions with shortcuts ctrl + d to duplicate, ctrl + p to pin. Duplicate and pin affects snapped blocks. Context menu displays when drag drop area receives a right click
|
@urbit-pilled Thanks for your effort here but #335 has opened first and reviews are ongoing. I would like to complete this issue :) |
|
I saw that it wasn't even compiling so I don't think you've made enough effort to lock this issue. @varshith257. |
|
@urbit-pilled That's a format issue and fixed it 😄 |
|
You made those fixes after mine. (Not that it was much work as most of it was done by @DoomTas3r) |
|
I believe it was more than a format issue otherwise I wouldn't have opened a PR, it also had compiler issues too. That's why I opened the PR. (Because a PR that doesn't compile means that you haven't even run it on your own computer yet) @varshith257 |
|
@urbit-pilled Nice, although some requested features from this proposal were left out, most notably the Ctrl-D shortcut to Duplicate. |
|
It was a bit ambiguous to me what @manuq wanted because later on he said that the other things should be discussed first. I have added back the Ctrl + d shortcut and added Delete to the dropdown menu. |
|
Thanks @urbit-pilled . I squashed the commits and took the liberty to improve the commit message in #345, while still giving credit to the original author @DoomTas3r. Thanks both. |
/claim #201
modified #293 so that it only contains the duplication feature. (removed pin, summary, and delete functionality)
Screen.Recording.2024-12-17.at.1.44.57.PM.mov