Move dialogue mouse-cursor handling to MouseManager#2087
Merged
Conversation
In commit b86ea32, logic was added to the dialogue balloon script to change the mouse cursor to a pointer when dialogue is shown, and back to the reticule/cross when it finishes. Move this logic to MouseManager, so that the code that adjusts the mouse cursor is all in one place. This also brings balloon.gd closer to the example script of which it is a copy, which helps when comparing to newer versions of the example balloon to bring more functionality forwards.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/move-dialogue-mouse-cursor-handling-to-mousemanager/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Mar 26, 2026
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
Much better, thanks for improving it.
manuq
deleted the
wjt/move-dialogue-mouse-cursor-handling-to-mousemanager
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move dialogue mouse-cursor handling to MouseManager
In commit b86ea32, logic was added to
the dialogue balloon script to change the mouse cursor to a pointer when
dialogue is shown, and back to the reticule/cross when it finishes.
Move this logic to MouseManager, so that the code that adjusts the mouse
cursor is all in one place. This also brings balloon.gd closer to the
example script of which it is a copy, which helps when comparing to
newer versions of the example balloon to bring more functionality
forwards.