Skip to content

Comments

Add Factory AI Droid agent integration#435

Draft
alishakawaguchi wants to merge 10 commits intomainfrom
alisha/factoryai-agent
Draft

Add Factory AI Droid agent integration#435
alishakawaguchi wants to merge 10 commits intomainfrom
alisha/factoryai-agent

Conversation

@alishakawaguchi
Copy link

@alishakawaguchi alishakawaguchi commented Feb 19, 2026 •
edited
Loading

Summary

  • Add Factory AI Droid as a new agent integration implementing the full Agent interface (hooks, transcripts, session lifecycle)
  • Fix transcript parsing and "(no prompt)" issue after commits by adding agent-specific transcript analysis
  • Implement GetSessionDir to enable transcript restoration for rewind, resume, and debug commands (~/.factory/sessions/<sanitized-repo-path>/)
  • Add comprehensive integration tests and E2E test runner for Droid sessions

Test plan

  • Unit tests for all Droid agent methods
  • Integration tests validating hook parsing, transcript chunking, session stubs, and session directory resolution
  • E2E test runner (E2E_AGENT=factoryai-droid) for real Droid session testing
  • mise run fmt && mise run lint && mise run test:ci all passing

🤖 Generated with Claude Code

alishakawaguchi and others added 5 commits February 19, 2026 10:02
@alishakawaguchi @claude
Add Factory AI Droid agent integration
3c37cf5 
Implement the agent.Agent interface for Factory AI Droid, including
session lifecycle management, hook handling, and JSONL transcript
parsing. Register the new agent in the agent registry and wire it
into config detection, hooks, and summarization.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 7fc7ad5b176b
@alishakawaguchi @claude
Fix Factory AI Droid transcript parsing and session lifecycle issues
bdf4c1a 
The Droid transcript parser was using the shared Claude Code parser which
expects {"type":"assistant",...} but Droid uses {"type":"message","message":
{"role":"assistant",...}}. This caused ExtractModifiedFiles to skip all lines,
preventing checkpoint creation entirely.

- Add Droid-specific JSONL parser (ParseDroidTranscript) that normalizes the
  envelope format by extracting message.role as Line.Type
- Wire Droid parser into all transcript analysis functions (lifecycle.go,
  transcript.go) replacing shared transcript.ParseFromFileAtLine calls
- Remove TranscriptPreparer/sentinel flush code (Droid never writes hook
  commands to JSONL, causing a 3s timeout on every turn-end)
- Add idempotent session-end handling for agents that fire SessionEnd twice
- Initialize session Phase to PhaseIdle in both strategies (was zero-value "")
- Update all test fixtures to use Droid JSONL format and add parser tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: fe59ba01b450
@alishakawaguchi @claude
Simplify Droid transcript parsing code
da2c18a 
- Replace IIFE pattern in ExtractSummary with idiomatic sequential error handling
- Remove single-use type aliases (assistantMessage, toolInput) in favor of
  direct transcript.AssistantMessage/transcript.ToolInput references
- Simplify ExtractAllModifiedFilesFromTranscript dedup since ExtractModifiedFiles
  already returns deduplicated results
- Consolidate makeWriteToolLine/makeEditToolLine into shared makeFileToolLine helper

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 979a49177542
@alishakawaguchi @claude
Add Factory AI Droid integration tests
c83248a 
Cover agent detection, hook installation, session stubs, enable command
smoke tests, and strategy composition for the factoryai-droid agent.
Unit tests for the agent package are also included.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 1a75b7499be8
@alishakawaguchi
Merge branch 'main' into alisha/factoryai-agent
cd0220e
Copilot AI review requested due to automatic review settings February 19, 2026 23:12
Copilot AI reviewed Feb 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds first-class support for the Factory AI Droid agent to Entire CLI, wiring it into agent registration, hook installation/handling, transcript parsing/analysis, and integration tests, while also improving session lifecycle robustness.

Changes:

  • Register the factoryai-droid agent (new agent type/name constants + agent package + CLI registration imports).
  • Add Factory Droid hook installation/uninstallation and transcript parsing/analyzers (including subagent-aware file/token extraction) with extensive tests.
  • Improve session lifecycle handling (initialize session Phase, and make SessionEnd handling idempotent).

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cmd/entire/cli/summarize/summarize.go Treats Factory Droid as a supported agent type for condensed transcript generation (currently routed through Claude parsing).
cmd/entire/cli/strategy/manual_commit_session.go Initializes new session state with an explicit Phase value.
cmd/entire/cli/strategy/auto_commit.go Initializes new session state with an explicit Phase value.
cmd/entire/cli/lifecycle.go Makes SessionEnd handling idempotent by skipping duplicate end events for already-ended sessions.
cmd/entire/cli/integration_test/setup_factoryai_hooks_test.go Adds integration smoke tests verifying hook installation and preservation of existing Factory settings.
cmd/entire/cli/integration_test/hooks.go Adds a Factory Droid hook runner and helpers for simulating hook flows in integration tests.
cmd/entire/cli/integration_test/agent_test.go Adds integration tests for Factory Droid agent detection, hook installation, and helper/stub behaviors.
cmd/entire/cli/integration_test/agent_strategy_test.go Adds end-to-end strategy composition tests for Factory Droid hooks → lifecycle → strategy checkpointing.
cmd/entire/cli/hooks_cmd.go Ensures the Factory Droid agent package is imported so it’s registered for hook subcommands.
cmd/entire/cli/config.go Ensures the Factory Droid agent package is imported so it’s registered for config/setup flows.
cmd/entire/cli/agent/registry.go Adds AgentNameFactoryAIDroid and AgentTypeFactoryAIDroid constants.
cmd/entire/cli/agent/factoryaidroid/types.go Introduces Factory settings schema types and transcript/tool constants used by the new agent.
cmd/entire/cli/agent/factoryaidroid/transcript.go Implements Droid transcript parsing/normalization plus modified-file and token/subagent extraction logic.
cmd/entire/cli/agent/factoryaidroid/transcript_test.go Adds unit tests for parsing, token usage calculations, and subagent-aware file extraction.
cmd/entire/cli/agent/factoryaidroid/lifecycle.go Implements lifecycle hook parsing and transcript analyzer/token calculator interfaces for Factory Droid.
cmd/entire/cli/agent/factoryaidroid/lifecycle_test.go Adds unit tests for lifecycle event parsing from hook payloads.
cmd/entire/cli/agent/factoryaidroid/hooks.go Implements Factory hook install/uninstall/idempotency plus permissions deny-rule enforcement.
cmd/entire/cli/agent/factoryaidroid/hooks_test.go Adds unit tests covering hook installation/uninstallation, idempotency, and preservation of user config.
cmd/entire/cli/agent/factoryaidroid/factoryaidroid.go Implements the core agent.Agent integration and self-registration for Factory Droid.
cmd/entire/cli/agent/factoryaidroid/factoryaidroid_test.go Adds unit tests for the Factory Droid agent’s basic behaviors and stubs.
CLAUDE.md Updates docs to mention the factoryai-droid stub option for E2E_AGENT.

alishakawaguchi and others added 3 commits February 20, 2026 11:51
@alishakawaguchi @claude
Fix Droid "(no prompt)" after commit by adding agent-specific transcr…
12d2099 
…ipt parsing

The condensation path re-extracted prompts from raw transcript bytes using a
generic Claude Code parser, which failed for Droid's different JSONL envelope
format. Added Droid-specific branches to extractUserPrompts(),
calculateTokenUsage(), and BuildCondensedTranscriptFromBytes() that normalize
via ParseDroidTranscriptFromBytes() before processing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 3a9059b7db5a
@alishakawaguchi @claude
Add Factory AI Droid E2E test runner
ac7c443 
Implement FactoryAIDroidRunner in the E2E test suite, enabling real
end-to-end testing with the droid CLI. Uses API key auth (FACTORY_API_KEY),
`droid exec` with --auto medium, and supports E2E_DROID_MODEL env var.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 6ca3fe47e9d9
@alishakawaguchi @claude
Implement GetSessionDir for Factory AI Droid
94a1d70 
Replace the "not implemented" stub with the real session directory path
(~/.factory/sessions/<sanitized-repo-path>/) so transcript restoration
works for rewind, resume, and debug commands.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 94658e608230
@alishakawaguchi alishakawaguchi changed the title WIP Add Factory AI Droid agent integration Feb 20, 2026
alishakawaguchi and others added 2 commits February 20, 2026 14:16
@alishakawaguchi
Merge branch 'main' into alisha/factoryai-agent
c5a1d93
@alishakawaguchi @claude
Add AgentTypeFactoryAIDroid to exhaustive switches and extract Droid …
c73ebfb 
…transcript helper

Fix exhaustive lint errors in explain.go by adding AgentTypeFactoryAIDroid
to the JSONL-based switch cases in scopeTranscriptForCheckpoint and
transcriptOffset. Extract inline Droid transcript parsing in summarize.go
into a dedicated buildCondensedTranscriptFromDroid helper for consistency
with other agent-specific parsers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: 0a6204bff3e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alishakawaguchi