Status optimization

cmd/entire/cli/bench_test.go

@@ -0,0 +1,85 @@
+package cli
+
+import (
+	"io"
+	"testing"
+
+	"github.com/entireio/cli/cmd/entire/cli/benchutil"
+	"github.com/entireio/cli/cmd/entire/cli/paths"
+	"github.com/entireio/cli/cmd/entire/cli/session"
+)
+
+/* To use the interactive flame graph, run:
+
+mise exec -- go tool pprof -http=:8089 /tmp/status_cpu.prof &>/dev/null & echo "pprof server started on http://localhost:8089"
+
+and then go to http://localhost:8089/ui/flamegraph
+
+*/
+
+// BenchmarkStatusCommand benchmarks the `entire status` command end-to-end.
+// This is the top-level entry point for understanding status command latency.
+//
+// Key I/O operations measured:
+//   - git rev-parse --show-toplevel (RepoRoot, cached after first call)
+//   - git rev-parse --git-common-dir (NewStateStore, per invocation)
+//   - git rev-parse --abbrev-ref HEAD (resolveWorktreeBranch, per unique worktree)
+//   - os.ReadFile for settings.json, each session state file
+//   - JSON unmarshaling for settings and each session state
+//
+// The primary scaling dimension is active session count.
+func BenchmarkStatusCommand(b *testing.B) {
+	b.Run("Short/NoSessions", benchStatus(0, false, true))
+	b.Run("Short/1Session", benchStatus(1, false, true))
+	b.Run("Short/5Sessions", benchStatus(5, false, true))
+	b.Run("Short/10Sessions", benchStatus(10, false, true))
+	b.Run("Short/20Sessions", benchStatus(20, false, true))
+	b.Run("Detailed/NoSessions", benchStatus(0, true, true))
+	b.Run("Detailed/5Sessions", benchStatus(5, true, true))
+}
+
+// BenchmarkStatusCommand_NoCache simulates the old behavior where getGitCommonDir
+// is uncached — every invocation spawns an extra git subprocess.
+func BenchmarkStatusCommand_NoCache(b *testing.B) {
+	b.Run("Short/NoSessions", benchStatus(0, false, false))
+	b.Run("Short/1Session", benchStatus(1, false, false))
+	b.Run("Short/5Sessions", benchStatus(5, false, false))
+	b.Run("Short/10Sessions", benchStatus(10, false, false))
+	b.Run("Short/20Sessions", benchStatus(20, false, false))
+	b.Run("Detailed/NoSessions", benchStatus(0, true, false))
+	b.Run("Detailed/5Sessions", benchStatus(5, true, false))
+}
+
+// benchStatus returns a benchmark function for the `entire status` command.
+// When useGitCommonDirCache is false, it clears the git common dir cache each
+// iteration to simulate the old uncached behavior.
+func benchStatus(sessionCount int, detailed, useGitCommonDirCache bool) func(*testing.B) {
+	return func(b *testing.B) {
+		repo := benchutil.NewBenchRepo(b, benchutil.RepoOpts{})
+
+		// Create active session state files in .git/entire-sessions/
+		for range sessionCount {
+			repo.CreateSessionState(b, benchutil.SessionOpts{})
+		}
+
+		// runStatus uses paths.RepoRoot() which requires cwd to be in the repo.
+		b.Chdir(repo.Dir)
+		paths.ClearRepoRootCache()
+		session.ClearGitCommonDirCache()
+
+		b.ResetTimer()
+		for range b.N {
+			// Always clear RepoRoot to simulate a fresh CLI invocation.
+			paths.ClearRepoRootCache()
+
+			if !useGitCommonDirCache {
+				// Simulate old behavior: no git common dir cache.
+				session.ClearGitCommonDirCache()
+			}
+
+			if err := runStatus(io.Discard, detailed); err != nil {
+				b.Fatalf("runStatus: %v", err)
+			}
+		}
+	}
+}

cmd/entire/cli/benchutil/benchutil.go

@@ -44,6 +44,9 @@ type BenchRepo struct {
 
 	// WorktreeID is the worktree identifier (empty for main worktree).
 	WorktreeID string
+
+	// Strategy is the strategy name used in .entire/settings.json.
+	Strategy string
 }
 
 // RepoOpts configures how NewBenchRepo creates the test repository.
@@ -167,6 +170,7 @@ func NewBenchRepo(b *testing.B, opts RepoOpts) *BenchRepo {
 		Repo:     repo,
 		Store:    checkpoint.NewGitStore(repo),
 		HeadHash: headHash.String(),
+		Strategy: opts.Strategy,
 	}
 
 	// Determine worktree ID
@@ -344,9 +348,17 @@ func (br *BenchRepo) WriteTranscriptFile(b *testing.B, sessionID string, data []
 // SeedShadowBranch creates N checkpoint commits on the shadow branch
 // for the current HEAD. This simulates a session that already has
 // prior checkpoints saved.
+//
+// Temporarily changes cwd to br.Dir because WriteTemporary uses
+// paths.RepoRoot() which depends on os.Getwd().
 func (br *BenchRepo) SeedShadowBranch(b *testing.B, sessionID string, checkpointCount int, filesPerCheckpoint int) {
 	b.Helper()
 
+	// WriteTemporary internally calls paths.RepoRoot() which uses os.Getwd().
+	// Switch cwd so it resolves to the bench repo.
+	b.Chdir(br.Dir)
+	paths.ClearRepoRootCache()
+
 	for i := range checkpointCount {
 		var modified []string
 		for j := range filesPerCheckpoint {
@@ -411,7 +423,7 @@ func (br *BenchRepo) SeedMetadataBranch(b *testing.B, checkpointCount int) {
 		err = br.Store.WriteCommitted(context.Background(), checkpoint.WriteCommittedOptions{
 			CheckpointID:     cpID,
 			SessionID:        sessionID,
-			Strategy:         "manual-commit",
+			Strategy:         br.Strategy,
 			Transcript:       transcript,
 			Prompts:          []string{fmt.Sprintf("Implement feature %d", i)},
 			FilesTouched:     files,