refactor: remove duplicate poll_for_swap_creation and use poll_for_swap_with_progress#146
Closed
Tet-9 wants to merge 3 commits into
Closed
refactor: remove duplicate poll_for_swap_creation and use poll_for_swap_with_progress#146Tet-9 wants to merge 3 commits into
Tet-9 wants to merge 3 commits into
Conversation
…rius#3) Previously fee_divisor minimum was 2 (allowing up to 50% fee on miner collateral per swap). Now enforced at minimum 20 (max 5%) in both the contract and CLI.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
Problem
poll_for_swap_creationinswap.pyis a weaker duplicate ofpoll_for_swap_with_progress. Both functions use the same pollinglogic, but
poll_for_swap_creationonly shows a static spinner whilepoll_for_swap_with_progressprovides better feedback with a liveelapsed-time counter like
0:03 elapsed.Fix
poll_for_swap_creationcall inpost_tx.pywithpoll_for_swap_with_progress, passing the already-availablestate.from_chainpoll_for_swap_creationfromswap.pyChanges
allways/cli/swap_commands/post_tx.py— usepoll_for_swap_with_progressallways/cli/swap_commands/swap.py— deletedpoll_for_swap_creation