fix: validate addresses in alw miner post before committing to chain#156
Closed
wdeveloper16 wants to merge 1 commit into
Closed
fix: validate addresses in alw miner post before committing to chain#156wdeveloper16 wants to merge 1 commit into
wdeveloper16 wants to merge 1 commit into
Conversation
Collaborator
|
duplicate identified |
Contributor
Author
|
Hi, @anderdc |
Contributor
Author
|
I think it's really needed before moving fulfillment |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #155
Summary
alw miner postaccepted any string as a BTC or TAO address and committed it to the subnet without validation. A miner who typos their receiving address becomes unable to receive funds from matched swaps — their collateral is at risk and users matched to them will experience failed fulfillments.What changed
allways/cli/swap_commands/pair.pycheck=Falseand callsis_valid_address()for both the source and destination addressBitcoinProviderandSubtensorProvidervalidate locally — no network connections are made[red]Invalid <ChainName> address: <addr>[/red]message and returns earlytests/test_pair_validation.py(new, 4 tests)Test Case
Before:
After: