refactor: move to_smallest_unit/from_smallest_unit to helpers.py#303
Open
Tet-9 wants to merge 1 commit into
Open
refactor: move to_smallest_unit/from_smallest_unit to helpers.py#303Tet-9 wants to merge 1 commit into
Tet-9 wants to merge 1 commit into
Conversation
The two chain-aware unit converters lived in swap.py as module-level privates while helpers.py already hosted the sibling to_rao/from_rao. quote.py also reimplemented to_smallest_unit inline with a raw Decimal expression. Move to_smallest_unit/from_smallest_unit into helpers.py next to to_rao/from_rao, update swap.py to import from helpers, and replace the inline expression in quote.py with a call to to_smallest_unit. Drop the now-unused Decimal import from quote.py. Fixes entrius#81
|
@anderdc , on for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_smallest_unitandfrom_smallest_unitlived inswap.pyasmodule-level privates while
helpers.pyalready hosted the siblingto_rao/from_raoconversions. Additionally,quote.pyreimplementedto_smallest_unitinline with a rawDecimalexpression — duplicatinglogic that already existed.
Changes
to_smallest_unit/from_smallest_unitfromswap.pyintohelpers.py, next toto_rao/from_raoswap.pyto import them fromhelpersinstead of defining locallyDecimalexpression inquote.pywith a call toto_smallest_unitand drop the now-unusedDecimalimportScope
Pure move + one callsite swap. No behavior change, no signature change.
Fixes #81