Therefactor: extract _metagraph_hotkey_to_uid helper in commitments.py#304
Open
Tet-9 wants to merge 1 commit into
Open
Therefactor: extract _metagraph_hotkey_to_uid helper in commitments.py#304Tet-9 wants to merge 1 commit into
Tet-9 wants to merge 1 commit into
Conversation
read_miner_commitment and read_miner_commitments both independently
built the same {hotkey: uid} map inline. Duplicate construction means
a future change to the map logic must be applied twice and callers
could accidentally use a stale copy.
Extract _metagraph_hotkey_to_uid(metagraph) and call it from both
functions so the map is always derived from the same snapshot.
Fixes entrius#169
|
@anderdc , on for review 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_miner_commitmentandread_miner_commitmentsboth independentlybuilt the same
{hotkey: uid}map inline:commitments.py:138—{metagraph.hotkeys[u]: u for u in range(metagraph.n.item())}commitments.py:160— identical expression with different loop variableDuplicate construction means a future change to the map logic must be
applied twice, and callers could accidentally use a stale copy.
Fix
Extract
_metagraph_hotkey_to_uid(metagraph)as a module-level privatehelper and call it from both functions so the map is always derived
from the same snapshot in one place.
Scope
Pure refactor. No behavior change, no signature change.
Fixes #169