Skip to content

Fetch base content for deleted PR files#21

Open
MkDev11 wants to merge 4 commits intoentrius:testfrom
MkDev11:fix/issue-20-deleted-file-base-content
Open

Fetch base content for deleted PR files#21
MkDev11 wants to merge 4 commits intoentrius:testfrom
MkDev11:fix/issue-20-deleted-file-base-content

Conversation

@MkDev11
Copy link
Copy Markdown

@MkDev11 MkDev11 commented May 8, 2026

Summary

  • Fetch base-side blob contents for removed PR files instead of filtering them out of PR file content fetching.
  • Skip head-side blob lookups for removed files, so deleted files persist base_content while head_content remains null.
  • Keep the patch focused on the accepted github-fetcher.service.ts change with no contributor test additions.

Related Issues

Closes #20

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Testing

  • npm run format:check
  • npm run lint
  • npm run build
  • git diff --check

Checklist

  • I have read the Contributing Guide
  • Code builds without errors
  • New and existing tests pass (if applicable)
  • Documentation updated (if applicable)
  • No unnecessary dependencies added

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 8, 2026
Copy link
Copy Markdown
Collaborator

@anderdc anderdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo doesn't accept tests in contributor PRs. Drop packages/das/src/webhook/github-fetcher.service.spec.ts. The github-fetcher.service.ts change itself is fine.

@MkDev11 MkDev11 requested a review from anderdc May 10, 2026 22:31
@MkDev11
Copy link
Copy Markdown
Author

MkDev11 commented May 10, 2026

This repo doesn't accept tests in contributor PRs. Drop packages/das/src/webhook/github-fetcher.service.spec.ts. The github-fetcher.service.ts change itself is fine.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Deleted PR files are marked complete without base content

2 participants