feat(dashboard): redesign Featured Contributors & Discoverers spotlight with centered row layout#880
Conversation
b290f76 to
92312cf
Compare
b52f036 to
49cbd01
Compare
49cbd01 to
9f25a79
Compare
|
Hi, @anderdc |
|
DRIFT detected — original PR premise tackled redesigning Featured Discoverers with responsive layout, the current state may not align. Flagging for maintainer review.
|
e35ventura
left a comment
There was a problem hiding this comment.
add tool tips to explain anything that isnt self explanatory. make sure all data is correct (some is displaying incorrect, example. 6 touched repos for discoveries is impossible). remove names of repos and show show PFPs. remove sentence from under the title.
Good catch! I'm on it. |
|
Addressed and fixed as you wanted. 10.05.2026_02.24.42_REC.mp4 |
|
Closing — same reasoning as #874: too complex, no clear takeaway from the section. The vertical horizontal-row layout breaks the dashboard's card-grid rhythm, eats roughly 3× the vertical space the current 3-column grid uses, and the two new spotlight files are ~80% duplicates of each other (123 of 662 lines differ). If you want to take another pass, the parts worth keeping are the rank-accent strip, the Eligible/Pending badge, and the section-level KPI strip — applied inside the existing 3-column grid, in a single shared component. |
1 similar comment
|
Closing — same reasoning as #874: too complex, no clear takeaway from the section. The vertical horizontal-row layout breaks the dashboard's card-grid rhythm, eats roughly 3× the vertical space the current 3-column grid uses, and the two new spotlight files are ~80% duplicates of each other (123 of 662 lines differ). If you want to take another pass, the parts worth keeping are the rank-accent strip, the Eligible/Pending badge, and the section-level KPI strip — applied inside the existing 3-column grid, in a single shared component. |
Summary
DashboardTopContributors3-column grid with a clean horizontal row card layout for bothFeaturedContributorsSpotlightandFeaturedDiscoverersSpotlight1fr auto 1fr) so the stats block is always visually centered and vertically aligned across all rowsdashboardData.tscontributor builders withscore,mergedPrs,closedPrs, andearningsfields to supply the new UIFeaturedContributorsSpotlightintoDashboardPagereplacing the old componentxs: 1fr auto auto,sm+: 1fr auto 1fr)Test plan
sm+): stats are centered between identity and repo pillsmd+screens, hidden on smallernpm run lint,tsc --noEmit, andnpm run buildall passCloses: #873
Screenshots