Skip to content

feat(dashboard): redesign Featured Contributors & Discoverers spotlight with centered row layout#880

Closed
dataCenter430 wants to merge 10 commits into
entrius:testfrom
dataCenter430:feat/featured-discoverers-redesign
Closed

feat(dashboard): redesign Featured Contributors & Discoverers spotlight with centered row layout#880
dataCenter430 wants to merge 10 commits into
entrius:testfrom
dataCenter430:feat/featured-discoverers-redesign

Conversation

@dataCenter430
Copy link
Copy Markdown
Contributor

@dataCenter430 dataCenter430 commented Apr 30, 2026

Summary

  • Replaced the old DashboardTopContributors 3-column grid with a clean horizontal row card layout for both FeaturedContributorsSpotlight and FeaturedDiscoverersSpotlight
  • Each card uses a 3-column CSS grid (1fr auto 1fr) so the stats block is always visually centered and vertically aligned across all rows
  • Added rank-accent left strip per card (gold/silver/bronze) as a visual differentiator
  • Score value rendered in a subtle boxed chip with rank accent color; cred progress bar also uses rank color
  • Full-width KPI strip added below each section header showing aggregated metrics
  • Removed left border section indicator from both spotlight wrappers for a cleaner look
  • Extended dashboardData.ts contributor builders with score, mergedPrs, closedPrs, and earnings fields to supply the new UI
  • Wired FeaturedContributorsSpotlight into DashboardPage replacing the old component
  • Fixed mobile responsive layout: KPI strip scrolls horizontally instead of overlapping; stats column right-aligns on small screens (xs: 1fr auto auto, sm+: 1fr auto 1fr)
  • Removed all unused imports and props; passes lint, TypeScript, and build checks

Test plan

  • Featured Contributors renders 3 rows with gold/silver/bronze left strips
  • Featured Discoverers renders 3 rows with gold/silver/bronze left strips
  • Stats column (score chip + count + cred bar) is vertically aligned across all 3 rows in both sections
  • KPI strip shows correct aggregated values
  • On mobile: KPI strip scrolls horizontally, stats are right-aligned
  • On desktop (sm+): stats are centered between identity and repo pills
  • Repo pills visible on md+ screens, hidden on smaller
  • Clicking a row navigates to the correct miner detail page
  • Loading and empty states render correctly
  • npm run lint, tsc --noEmit, and npm run build all pass

Closes: #873

Screenshots

image

@xiao-xiao-mao xiao-xiao-mao Bot added the feature Net-new functionality label Apr 30, 2026
@dataCenter430 dataCenter430 force-pushed the feat/featured-discoverers-redesign branch 3 times, most recently from b290f76 to 92312cf Compare April 30, 2026 05:33
@dataCenter430 dataCenter430 marked this pull request as draft April 30, 2026 16:51
@dataCenter430 dataCenter430 deleted the feat/featured-discoverers-redesign branch April 30, 2026 17:49
@dataCenter430 dataCenter430 restored the feat/featured-discoverers-redesign branch April 30, 2026 17:50
@dataCenter430 dataCenter430 reopened this Apr 30, 2026
@dataCenter430 dataCenter430 deleted the feat/featured-discoverers-redesign branch April 30, 2026 17:59
@dataCenter430 dataCenter430 restored the feat/featured-discoverers-redesign branch April 30, 2026 17:59
@dataCenter430 dataCenter430 reopened this Apr 30, 2026
@dataCenter430 dataCenter430 deleted the feat/featured-discoverers-redesign branch April 30, 2026 18:01
@dataCenter430 dataCenter430 restored the feat/featured-discoverers-redesign branch April 30, 2026 18:02
@dataCenter430 dataCenter430 reopened this Apr 30, 2026
@dataCenter430 dataCenter430 force-pushed the feat/featured-discoverers-redesign branch 2 times, most recently from b52f036 to 49cbd01 Compare April 30, 2026 18:29
@dataCenter430 dataCenter430 force-pushed the feat/featured-discoverers-redesign branch from 49cbd01 to 9f25a79 Compare April 30, 2026 18:33
@dataCenter430 dataCenter430 changed the title feat: redesign Featured Discoverers with responsive layout feat(dashboard): redesign Featured Contributors & Discoverers spotlight with centered row layout Apr 30, 2026
@dataCenter430 dataCenter430 marked this pull request as ready for review April 30, 2026 22:19
@xiao-xiao-mao xiao-xiao-mao Bot added drift and removed feature Net-new functionality labels May 4, 2026
@dataCenter430
Copy link
Copy Markdown
Contributor Author

Hi, @anderdc
I'd appreciate your feedback with this.

@xiao-xiao-mao
Copy link
Copy Markdown

xiao-xiao-mao Bot commented May 4, 2026

DRIFT detected — original PR premise tackled redesigning Featured Discoverers with responsive layout, the current state may not align. Flagging for maintainer review.

Copy link
Copy Markdown
Collaborator

@e35ventura e35ventura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tool tips to explain anything that isnt self explanatory. make sure all data is correct (some is displaying incorrect, example. 6 touched repos for discoveries is impossible). remove names of repos and show show PFPs. remove sentence from under the title.

@dataCenter430
Copy link
Copy Markdown
Contributor Author

add tool tips to explain anything that isnt self explanatory. make sure all data is correct (some is displaying incorrect, example. 6 touched repos for discoveries is impossible). remove names of repos and show show PFPs. remove sentence from under the title.

Good catch! I'm on it.

@dataCenter430
Copy link
Copy Markdown
Contributor Author

Addressed and fixed as you wanted.
Ready to review.

10.05.2026_02.24.42_REC.mp4

@dataCenter430 dataCenter430 requested a review from e35ventura May 10, 2026 06:30
@ventura-oss
Copy link
Copy Markdown
Contributor

Closing — same reasoning as #874: too complex, no clear takeaway from the section. The vertical horizontal-row layout breaks the dashboard's card-grid rhythm, eats roughly 3× the vertical space the current 3-column grid uses, and the two new spotlight files are ~80% duplicates of each other (123 of 662 lines differ). If you want to take another pass, the parts worth keeping are the rank-accent strip, the Eligible/Pending badge, and the section-level KPI strip — applied inside the existing 3-column grid, in a single shared component.

1 similar comment
@ventura-oss
Copy link
Copy Markdown
Contributor

Closing — same reasoning as #874: too complex, no clear takeaway from the section. The vertical horizontal-row layout breaks the dashboard's card-grid rhythm, eats roughly 3× the vertical space the current 3-column grid uses, and the two new spotlight files are ~80% duplicates of each other (123 of 662 lines differ). If you want to take another pass, the parts worth keeping are the rank-accent strip, the Eligible/Pending badge, and the section-level KPI strip — applied inside the existing 3-column grid, in a single shared component.

@e35ventura e35ventura closed this May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign dashboard featured contributor and discoverer sections

3 participants