fix(cli): reject GraphQL semantic failures in PAT preflight#1201
Closed
Desel72 wants to merge 1 commit into
Closed
fix(cli): reject GraphQL semantic failures in PAT preflight#1201Desel72 wants to merge 1 commit into
Desel72 wants to merge 1 commit into
Conversation
Collaborator
|
duplicate of #1196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align
gitt miner postlocal PAT preflight with validator-side GraphQL semantics.This change makes CLI preflight reject PATs when GitHub GraphQL returns HTTP 200 but:
errorsis present, ordata.vieweris null/missing.It prevents false-positive "PAT is valid" results in CLI that later fail validator checks.
Related Issues
Closes #1199
Type of Change
Testing
Added CLI unit tests for:
errors=> rejectviewer: null=> rejectNote: Full pytest execution in this environment is blocked by missing dependency
richat import time.Checklist