fix: don't count same-account solves toward MIN_VALID_SOLVED_ISSUES gate#1256
Open
hunnyboy1217 wants to merge 1 commit into
Open
fix: don't count same-account solves toward MIN_VALID_SOLVED_ISSUES gate#1256hunnyboy1217 wants to merge 1 commit into
hunnyboy1217 wants to merge 1 commit into
Conversation
Move the same-account check ahead of the valid_solved_count increment so self-filed-and-self-solved issues stay inert to the discovery eligibility gate, matching the module docstring's stated anti-self-issue gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the same-account (
discoverer == solver) check ahead of thevalid_solved_countincrement in_score_miner_mirror_issuesso self-filed-and-self-solved issues no longer count toward theMIN_VALID_SOLVED_ISSUES = 7eligibility gate. Previously the counter incremented at mirror_scan.py:328-329 before the same-accountcontinueat line 332, letting a miner satisfy the gate with self-loops despite the module docstring listing "anti-self-issue" as an applied anti-gaming gate (mirror_scan.py:19).After this PR: same-account solves still bump
total_solved_issues(credibility) but do not bumptotal_valid_solved_issues, so they cannot satisfy the discovery eligibility gate.Related Issues
Fixes #1255
Type of Change
Testing
Extended
test_self_issue_counts_credibility_but_no_scorein tests/validator/issue_discovery/test_mirror_scan.py withassert eval_.total_valid_solved_issues == 0to lock in the gate-bypass fix.Test runs:
Checklist
Notes for reviewers
valid_solved_countanyway since the increment is gated on the sameMIN_TOKEN_SCORE_FOR_BASE_SCOREthreshold.