fix: move same-account check before valid_solved_count increment (#1255)#1257
Open
alpurkan17 wants to merge 1 commit into
Open
fix: move same-account check before valid_solved_count increment (#1255)#1257alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorder the same-account check (
issue.author_github_id == solving_pr.author_github_id) to happen beforevalid_solved_countis incremented. Previously a miner who filed an issue and solved it with their own PR had that issue counted towardvalid_solved_count, bypassingMIN_VALID_SOLVED_ISSUESeligibility gate.Validation
ruff check+ruff formatpassCloses #1255