refactor: remove unused parse_repo_name and its Dict import#1258
Open
ebios-star wants to merge 1 commit into
Open
refactor: remove unused parse_repo_name and its Dict import#1258ebios-star wants to merge 1 commit into
ebios-star wants to merge 1 commit into
Conversation
parse_repo_name was the legacy GraphQL response parser that wrapped repo_data['owner']['login'] + repo_data['name'] into a lowercased 'owner/repo' string. The legacy scoring pipeline that called it was stripped in entrius#1202, and the mirror path uses MirrorPullRequest.repo_full_name directly (already lowercased at parse time in MirrorPullRequest.from_dict). grep -rn parse_repo_name across gittensor/, neurons/, and tests/ returns only the definition line. Dropping the function also frees the only consumer of 'from typing import Dict' in this module, so the import goes with it.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_repo_namewas the legacy GraphQL-response parser that wrappedrepo_data['owner']['login'] + '/' + repo_data['name']into a lowercased'owner/repo'string. The legacy scoring pipeline that called it was stripped in #1202, and the mirror path usesMirrorPullRequest.repo_full_namedirectly (already lowercased at parse time inMirrorPullRequest.from_dict).grep -rn parse_repo_name --include='*.py' .acrossgittensor/,neurons/, andtests/returns only the definition line — no remaining call sites.Dropping the function also frees the only consumer of
from typing import Dictin this module, so the import goes with it.Net: -6 lines, single file. Matches the dead-code-removal precedent from #437, #448, #466.
Type of Change
Testing
pytest tests/— all 725 tests pass.Checklist