fix: move unique_repos tracking before file changes check to prevent KeyError

[0xsatoshi99]

Problem

Fixes #66

The apply_cross_miner_multipliers_and_finalize function crashes with KeyError when a PR has no file changes.

Root Cause

In score_pull_requests, the line:

miner_eval.unique_repos_contributed_to.add(pr.repository_full_name)

was placed AFTER the continue statement that skips PRs with no file changes. This means PRs without file changes never get their repository added to unique_repos_contributed_to.

Later, apply_cross_miner_multipliers_and_finalize tries to access repo_counts[pr.repository_full_name] which raises KeyError because the repo was never counted.

Fix

Move unique_repos_contributed_to.add() to the beginning of the loop, before the file changes check. This ensures ALL valid PRs contribute to repository uniqueness regardless of whether they have file changes.

Impact

• Prevents validator crashes when PRs have no file changes
• Ensures correct uniqueness calculation for all valid PRs
• Minimal change: 2 lines moved, 2 lines of comments added
• Zero breaking changes

---

Contribution by Gittensor, learn more at https://gittensor.io/

[0xsatoshi99]

@LandynDev , @SmartDever02 Can you plz check this PR?

[anderdc]

your PRs are not pointed to the test branch. These will not get merged unless that is fixed

[LandynDev]

You raise a good point here. I'd actually prefer a fix more directly in the miner_eval.add_pull_request helper function. Can we move it there so that when a PR is added via this helper function, it just automatically appends to our unique_repos_contributed_to: Set[str]?

[0xsatoshi99]

You raise a good point here. I'd actually prefer a fix more directly in the miner_eval.add_pull_request helper function. Can we move it there so that when a PR is added via this helper function, it just automatically appends to our unique_repos_contributed_to: Set[str]?

Fixed as what you want, Please check again. Thanks.

[LandynDev]

Can we remove some of these comments? We don't need to be maxing the diff out, like this is super verbose and unnecessary for a simple helper function:

        Automatically tracks the repository in unique_repos_contributed_to
        to prevent KeyError in apply_cross_miner_multipliers_and_finalize
        when calculating uniqueness multipliers.

So can we restore the doc string of the add_pull_request function?

[LandynDev]

Can we remove some of these comments? We don't need to be maxing the diff out, like this is super verbose and unnecessary for a simple helper function:

        Automatically tracks the repository in unique_repos_contributed_to
        to prevent KeyError in apply_cross_miner_multipliers_and_finalize
        when calculating uniqueness multipliers.

So can we restore the doc string of the add_pull_request function?

Then im ready to GTM 👍