Skip to content

header_mutation: fix the uri query encoding#43502

Merged
botengyao merged 3 commits intoenvoyproxy:mainfrom
botengyao:header_mutation_bug
Feb 18, 2026
Merged

header_mutation: fix the uri query encoding#43502
botengyao merged 3 commits intoenvoyproxy:mainfrom
botengyao:header_mutation_bug

Conversation

@botengyao
Copy link
Member

Fixed a issue where query parameter values added via query_parameter_mutations were not URL-encoded, allowing query parameter injection attacks. Values from formatters like %REQ(header)% are now properly URL-encoded when added to the query string. This behavior is controlled by the runtime guard envoy.reloadable_features.header_mutation_url_encode_query_params.

Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #43502 was opened by botengyao.

see: more, trace.

agrawroh
agrawroh previously approved these changes Feb 16, 2026
Copy link
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @botengyao!

Signed-off-by: Boteng Yao <boteng@google.com>
@botengyao botengyao merged commit be601de into envoyproxy:main Feb 18, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants