Check if EnvoyQuicServerStream has been reset when it gets unblocked.#43527
Closed
wang178c wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
Check if EnvoyQuicServerStream has been reset when it gets unblocked.#43527wang178c wants to merge 2 commits intoenvoyproxy:mainfrom
wang178c wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Haoyue Wang <haoyuewang@google.com>
Contributor
Author
|
/assign @danzh2010 |
Signed-off-by: Haoyue Wang <haoyuewang@google.com>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
|
Per offline discussion, fixing the issue in QUIC layer instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Check if EnvoyQuicServerStream has been reset when it gets unblocked.
Additional Description: If the stream has been reset, there is no need to send more data upstream.
Risk Level: Low. Guarded by false runtime guard envoy.reloadable_features.quic_disable_data_read_immediately.