tracing: fix sampling priority escalation on route cache refresh#43528
Draft
bvandewalle wants to merge 3 commits intoenvoyproxy:mainfrom
Draft
tracing: fix sampling priority escalation on route cache refresh#43528bvandewalle wants to merge 3 commits intoenvoyproxy:mainfrom
bvandewalle wants to merge 3 commits intoenvoyproxy:mainfrom
Conversation
bvandewalle
had a problem deploying
to
external-contributors
GitHub Actions
Error
|
Hi @bvandewalle, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Bernard Van De Walle <bernard@bvandewa.com>
Signed-off-by: Bernard Van De Walle <bernard@bvandewa.com>
Signed-off-by: Bernard Van De Walle <bernard@bvandewa.com>
bvandewalle
force-pushed
the
fix-refresh-tracing-priority
branch
from
24907f6 to
22c0335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Fixed a possible priority change upon recalculating tracing on a route after a ClearRouteCache.
Additional Description: Fixed route refresh tracing to not override the tracer's sampling decision when the trace is kept. Previously, a route refresh could escalate the sampling priority, preventing downstream trace collectors from applying their own sampling rates.
Risk Level: low
Testing: Added a unit test.
Docs Changes: N/A
Release Notes: Fixed route refresh tracing to not override the tracer's sampling decision when the trace is kept. Previously, a route refresh could escalate the sampling priority, preventing downstream trace collectors from applying their own sampling rates.
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]