Skip to content

tcp_proxy: fix OD-CDS over ADS#43529

Open
adisuissa wants to merge 5 commits intoenvoyproxy:mainfrom
adisuissa:tcp_proxy_odcds_over_ads_fix
Open

tcp_proxy: fix OD-CDS over ADS#43529
adisuissa wants to merge 5 commits intoenvoyproxy:mainfrom
adisuissa:tcp_proxy_odcds_over_ads_fix

Conversation

@adisuissa
Copy link
Contributor

Commit Message: tcp_proxy: fix OD-CDS over ADS
Additional Description:
This PR is similar to #41174 (and uses the same component to achieve the same goal).
The fix allows proper use of tcp_proxy on-demand cluster discovery when used over ADS.

Risk Level: low - only impacts OD-CDS over tcp_proxy
Testing: Added integration tests.
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
Runtime guard: Added envoy.reloadable_features.tcp_proxy_odcds_over_ads_fix to disable the behavior.

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #43529 was opened by adisuissa.

see: more, trace.

…r_ads_fix

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa adisuissa marked this pull request as ready for review February 18, 2026 14:09
@repokitteh-read-only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #43529 was ready_for_review by adisuissa.

see: more, trace.

@adisuissa
Copy link
Contributor Author

Assigning the same maintainers from #41174 and a senior-maintainer
/assign @KBaichoo @nezdolik @botengyao

…r_ads_fix

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
KBaichoo
KBaichoo previously approved these changes Feb 18, 2026
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments