dynamic_modules: add bool metadata, metadata keys/namespaces, and bool attribute ABI (http)#43537
Open
kanurag94 wants to merge 5 commits intoenvoyproxy:mainfrom
Open
dynamic_modules: add bool metadata, metadata keys/namespaces, and bool attribute ABI (http)#43537kanurag94 wants to merge 5 commits intoenvoyproxy:mainfrom
kanurag94 wants to merge 5 commits intoenvoyproxy:mainfrom
Conversation
…l attribute ABI Signed-off-by: Anurag Aggarwal <kanurag94@gmail.com>
Signed-off-by: Anurag Aggarwal <kanurag94@gmail.com>
Signed-off-by: Anurag Aggarwal <kanurag94@gmail.com>
Signed-off-by: Anurag Aggarwal <kanurag94@gmail.com>
Signed-off-by: Anurag Aggarwal <kanurag94@gmail.com>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dynamic_modules: add bool metadata, metadata keys/namespaces, and bool attribute ABI
Additional Description: Extends the dynamic modules ABI and SDK (Go + C++) with:
GetMetadataBool/SetMetadataBool— bool metadata getter/setterGetMetadataKeys— Get all keys a metadata namespaceGetMetadataNamespaces— Get all metadata namespace namesGetAttributeBool— bool attribute getter (e.g. ConnectionMtls)Risk Level: Low
Testing: Added C++ unit tests for all new ABI functions + Go integration test extensions. Manually tested with a Go dynamic module against envoy build
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue]: N/A
[Optional Fixes commit #PR or SHA]: N/A
[Optional Deprecated:]: N/A
[Optional API Considerations:] N/A