fix(xds): preserve original host metadata for DFP rewrites#8610
Open
officialasishkumar wants to merge 1 commit intoenvoyproxy:mainfrom
Open
fix(xds): preserve original host metadata for DFP rewrites#8610officialasishkumar wants to merge 1 commit intoenvoyproxy:mainfrom
officialasishkumar wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Member
|
are you sure that this fixed the issue? |
Keep the route-level host rewrite metadata in place for dynamic forward proxy routes so Envoy can still emit the original host headers, while DFP per-route config continues to drive DNS resolution. Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
officialasishkumar
force-pushed
the
fix/dfp-original-host-header
branch
from
46cc646 to
f6a5cbc
Compare
Author
|
@zirain yes |
Member
I tested it locally, and it didn't find it worked(maybe i missed something). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix(xds): preserve original host metadata for DFP rewrites
What this PR does / why we need it:
Dynamic forward proxy host rewrites were clearing the route-level host rewrite metadata after the per-route DFP config was added. That left Envoy without the router-level information it uses to emit
X-ENVOY-ORIGINAL-HOST, even though the rewritten host still drove DNS resolution. This change keeps the route host rewrite metadata in place, adds a focused regression test for both header and literal rewrites, and updates the translator golden output accordingly.Which issue(s) this PR fixes:
Fixes #8353
Release Notes: Yes