Skip to content

fix json report#8614

Merged
cnvergence merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-json-report
Mar 30, 2026
Merged

fix json report#8614
cnvergence merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-json-report

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Mar 30, 2026

Nighthawk emits nearby histogram percentiles instead of exact decimal values, for example the benchmark testdata shows values like:

  Percentile  Count   Value
  0.500000    17999   478.255µs
  0.750000    27001   494.671µs
  0.800000    28801   500.831µs
  0.900000    32398   524.479µs
  0.950000    34199   565.567µs
  0.990625    35660   1.174719ms
  0.999023    35962   4.073215ms

The current Json file will output 0 for P99.

        "percentiles": {
          "p50": 0.47825500000000004,
          "p75": 0.494671,
          "p80": 0.500831,
          "p90": 0.524479,
          "p95": 0.565567,
          "p99": 0,
          "p999": 0
        }

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner March 30, 2026 06:08
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 2656297
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69ca136e35f4a000080120d7

@zhaohuabing zhaohuabing requested a review from zirain March 30, 2026 06:08
@zhaohuabing zhaohuabing requested a review from a team March 30, 2026 06:13
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.31%. Comparing base (945fe9f) to head (2656297).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8614      +/-   ##
==========================================
- Coverage   74.33%   74.31%   -0.03%     
==========================================
  Files         243      243              
  Lines       38155    38155              
==========================================
- Hits        28364    28354      -10     
- Misses       7802     7809       +7     
- Partials     1989     1992       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cnvergence cnvergence merged commit 4768ca7 into envoyproxy:main Mar 30, 2026
99 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants