Add everest gradient plots#12892
Conversation
bd1b408 to
f5b2eca
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12892 +/- ##
==========================================
- Coverage 90.52% 90.20% -0.32%
==========================================
Files 443 445 +2
Lines 30595 30763 +168
==========================================
+ Hits 27697 27751 +54
- Misses 2898 3012 +114
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f5b2eca to
24ec543
Compare
Merging this PR will improve performance by 81.96%
Performance Changes
Comparing |
07599e5 to
054657b
Compare
054657b to
343fc77
Compare
c2c2db9 to
d047b4c
Compare
d047b4c to
cbf0c56
Compare
| ) -> Response: | ||
| try: | ||
| ensemble = storage.get_ensemble(ensemble_id) | ||
| except KeyError as e: |
There was a problem hiding this comment.
I added #12934 on which you can cherry-pick rebase.
The data_for_gradient should probably also be wrapped in the context manager for consistency with get_response
| ): | ||
| ensemble_to_data_map[ensemble] = self._api.data_for_parameter( | ||
| data = self._api.data_for_parameter( | ||
| ensemble_id=ensemble.id, |
There was a problem hiding this comment.
(an alternative to using threads could be to supply a list of ensemble id's here - changing the api as needed)
There was a problem hiding this comment.
No, probably not a very good idea.
| unquoted_key = unquote(key) | ||
| dataframe = data_for_gradient(ensemble, unquoted_key) | ||
|
|
||
| media_type = accept if accept is not None else "text/csv" |
There was a problem hiding this comment.
I take it that accept are acceptable media types? Not very intuitive argument perhaps?
There was a problem hiding this comment.
Yep, suggest leaving rename / maybe a small refactor for separate issue/PR though, this is also in parameters.py
There was a problem hiding this comment.
I think this can be made nice with a match construct.
Approach:
