Skip to content

Add everest gradient plots#12892

Merged
berland merged 2 commits intoequinor:mainfrom
yngve-sk:26.02.add-ever-gradient-plots
Feb 19, 2026
Merged

Add everest gradient plots#12892
berland merged 2 commits intoequinor:mainfrom
yngve-sk:26.02.add-ever-gradient-plots

Conversation

@yngve-sk
Copy link
Copy Markdown
Contributor

@yngve-sk yngve-sk commented Feb 16, 2026

Approach:
Screenshot 2026-02-16 at 15 42 48

@yngve-sk yngve-sk self-assigned this Feb 16, 2026
@yngve-sk yngve-sk added this to SCOUT Feb 16, 2026
@yngve-sk yngve-sk moved this to In Progress in SCOUT Feb 16, 2026
@yngve-sk yngve-sk force-pushed the 26.02.add-ever-gradient-plots branch 4 times, most recently from bd1b408 to f5b2eca Compare February 17, 2026 07:50
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 34.88372% with 112 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.20%. Comparing base (6b61bdd) to head (cbf0c56).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ools/plot/plottery/plots/everest_gradients_plot.py 13.11% 53 Missing ⚠️
src/ert/dark_storage/endpoints/responses.py 9.37% 29 Missing ⚠️
src/ert/gui/tools/plot/plot_window.py 66.66% 12 Missing ⚠️
...s/plot/widgets/everest_control_selection_widget.py 68.75% 10 Missing ⚠️
src/ert/gui/tools/plot/plot_api.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12892      +/-   ##
==========================================
- Coverage   90.52%   90.20%   -0.32%     
==========================================
  Files         443      445       +2     
  Lines       30595    30763     +168     
==========================================
+ Hits        27697    27751      +54     
- Misses       2898     3012     +114     
Flag Coverage Δ
cli-tests 36.89% <0.00%> (-0.23%) ⬇️
gui-tests 67.49% <33.13%> (-0.22%) ⬇️
performance-and-unit-tests 76.78% <34.88%> (-0.25%) ⬇️
test 46.13% <15.11%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk force-pushed the 26.02.add-ever-gradient-plots branch from f5b2eca to 24ec543 Compare February 17, 2026 08:31
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 17, 2026

Merging this PR will improve performance by 81.96%

⚡ 1 improved benchmark
✅ 33 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_parquet] 40 ms 22 ms +81.96%

Comparing yngve-sk:26.02.add-ever-gradient-plots (cbf0c56) with main (f3122f2)

Open in CodSpeed

@yngve-sk yngve-sk force-pushed the 26.02.add-ever-gradient-plots branch 5 times, most recently from 07599e5 to 054657b Compare February 18, 2026 12:31
@yngve-sk yngve-sk force-pushed the 26.02.add-ever-gradient-plots branch from 054657b to 343fc77 Compare February 18, 2026 12:41
@yngve-sk yngve-sk moved this from In Progress to Ready for Review in SCOUT Feb 18, 2026
@yngve-sk yngve-sk force-pushed the 26.02.add-ever-gradient-plots branch from c2c2db9 to d047b4c Compare February 18, 2026 14:11
@yngve-sk yngve-sk force-pushed the 26.02.add-ever-gradient-plots branch from d047b4c to cbf0c56 Compare February 18, 2026 14:27
) -> Response:
try:
ensemble = storage.get_ensemble(ensemble_id)
except KeyError as e:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added #12934 on which you can cherry-pick rebase.

The data_for_gradient should probably also be wrapped in the context manager for consistency with get_response

):
ensemble_to_data_map[ensemble] = self._api.data_for_parameter(
data = self._api.data_for_parameter(
ensemble_id=ensemble.id,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(an alternative to using threads could be to supply a list of ensemble id's here - changing the api as needed)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, probably not a very good idea.

unquoted_key = unquote(key)
dataframe = data_for_gradient(ensemble, unquoted_key)

media_type = accept if accept is not None else "text/csv"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it that accept are acceptable media types? Not very intuitive argument perhaps?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, suggest leaving rename / maybe a small refactor for separate issue/PR though, this is also in parameters.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be made nice with a match construct.

Copy link
Copy Markdown
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@github-project-automation github-project-automation Bot moved this from Ready for Review to Reviewed in SCOUT Feb 19, 2026
@berland berland added the release-notes:new-feature Automatically categorise as new feature in release notes label Feb 19, 2026
@berland berland merged commit 6b3c53a into equinor:main Feb 19, 2026
36 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in SCOUT Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:new-feature Automatically categorise as new feature in release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants