Skip to content

Add batch total objective plots to ERT plotter#12900

Merged
berland merged 5 commits intoequinor:mainfrom
yngve-sk:26.02.add-ever-batch-plots
Feb 19, 2026
Merged

Add batch total objective plots to ERT plotter#12900
berland merged 5 commits intoequinor:mainfrom
yngve-sk:26.02.add-ever-batch-plots

Conversation

@yngve-sk
Copy link
Copy Markdown
Contributor

@yngve-sk yngve-sk commented Feb 17, 2026

Screenshot 2026-02-17 at 10 27 00

@yngve-sk yngve-sk force-pushed the 26.02.add-ever-batch-plots branch from cd9def7 to 020c9d7 Compare February 19, 2026 09:43
@yngve-sk yngve-sk force-pushed the 26.02.add-ever-batch-plots branch from 0a52e8d to 392f68e Compare February 19, 2026 11:18
@yngve-sk yngve-sk marked this pull request as ready for review February 19, 2026 11:19
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 14.28571% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.10%. Comparing base (6b3c53a) to head (57104fb).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../plot/plottery/plots/values_over_iteration_plot.py 5.55% 17 Missing ⚠️
src/ert/dark_storage/endpoints/responses.py 7.14% 13 Missing ⚠️
src/ert/gui/tools/plot/plot_api.py 33.33% 4 Missing ⚠️
src/ert/gui/tools/plot/plot_window.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12900      +/-   ##
==========================================
- Coverage   90.22%   90.10%   -0.12%     
==========================================
  Files         445      445              
  Lines       30763    30841      +78     
==========================================
+ Hits        27755    27789      +34     
- Misses       3008     3052      +44     
Flag Coverage Δ
cli-tests 36.83% <0.00%> (-0.07%) ⬇️
gui-tests 67.38% <11.90%> (-0.12%) ⬇️
performance-and-unit-tests 76.71% <14.28%> (-0.09%) ⬇️
test 46.01% <2.38%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 19, 2026

Merging this PR will not alter performance

✅ 34 untouched benchmarks


Comparing yngve-sk:26.02.add-ever-batch-plots (57104fb) with main (dd0ca6f)

Open in CodSpeed

@berland berland added this to SCOUT Feb 19, 2026
@berland berland moved this to Ready for Review in SCOUT Feb 19, 2026

axes.set_xlabel("Iteration")
axes.set_ylabel(value_col)
axes.set_title(f"{value_col} over iterations")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the title, the information is already in the axis labels.

Copy link
Copy Markdown
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final go!

@github-project-automation github-project-automation Bot moved this from Ready for Review to Reviewed in SCOUT Feb 19, 2026
@berland berland added the release-notes:new-feature Automatically categorise as new feature in release notes label Feb 19, 2026
@berland berland enabled auto-merge (squash) February 19, 2026 14:44
@berland berland merged commit e3a1259 into equinor:main Feb 19, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in SCOUT Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:new-feature Automatically categorise as new feature in release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants