Squash logs#12933
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12933 +/- ##
==========================================
- Coverage 90.22% 90.11% -0.11%
==========================================
Files 445 445
Lines 30763 30851 +88
==========================================
+ Hits 27755 27802 +47
- Misses 3008 3049 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Only need to rewrite the test |
13d9971 to
ec0afd3
Compare
|
Ert itself does not log anything to Azure, so it feels weird to impose Azure limitations into Ert's codebase. The plugin typically used for logging to Azure from Ert already has this batching capability, is that not sufficient? |
Guess it depends on if you care where the string gets split |
I think we can live with the random split-points that we currently get from the logging plugin. It is possible to programmatically reassemble the long strings if really needed. |
berland
left a comment
There was a problem hiding this comment.
I think it looks good!
There is the question of whether sample_prior would be slower since we now loop twice over all parameters, but it does not look like the looping itself is expensive (and it becomes faster due to less logger.info calls)
|
A release note label is needed. There is one related to logging. |
Issue
Resolves #12921